Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to the PV of an OVA provider #685

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Dec 18, 2023

There is no point in setting the OVA provider as the owner of the PV we
create for it since the PV is not namespace-scoped and thus, it is not
removed when the OVA provider is removed.

Signed-off-by: Arik Hadas <[email protected]>
The PV is currently not set with a reclaim policy and therefore it
defaults to 'Retain' which is conceptually incorrect since it is
supposed to be removed when the OVA provider is removed.

Here we set the reclaim policy of the PV to 'Delete' instead. While the
PV would still remain after the OVA provider is removed (since the PV is
not set with a storage class and therefore there is no driver that can
remove it), the state of the PV would change to 'Failed' rather than
'Released' in this case, which better reflects its true state. Removing
the PV for an OVA provider when the latter is removed will be addressed
separately.

Signed-off-by: Arik Hadas <[email protected]>
@ahadas ahadas requested review from liranr23 and bkhizgiy December 18, 2023 21:58
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ahadas ahadas merged commit 822cb8b into kubev2v:main Dec 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants